Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update golang to 1.18.3 #1417

Merged
merged 2 commits into from
Jun 29, 2022
Merged

feat: update golang to 1.18.3 #1417

merged 2 commits into from
Jun 29, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 29, 2022

Description

  • Update golang to 1.18.3.
  • Updata alpine linux to 3.16.
  • Update grpc-health-probe to 0.4.11.
  • Update dependencies.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 29, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 29, 2022 04:55
@gaius-qi gaius-qi self-assigned this Jun 29, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 29, 2022 04:55
@codecov-commenter
Copy link

Codecov Report

Merging #1417 (680af4a) into main (4bca2c6) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   45.01%   44.77%   -0.25%     
==========================================
  Files         110      110              
  Lines       10049    10049              
==========================================
- Hits         4524     4499      -25     
- Misses       5060     5088      +28     
+ Partials      465      462       -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 44.77% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 46.75% <0.00%> (-0.87%) ⬇️
client/daemon/peer/peertask_conductor.go 58.14% <0.00%> (ø)

@gaius-qi gaius-qi force-pushed the feature/go-1.18.3 branch 2 times, most recently from 397d243 to 855c87f Compare June 29, 2022 06:53
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit fa04316 into main Jun 29, 2022
@gaius-qi gaius-qi deleted the feature/go-1.18.3 branch June 29, 2022 07:34
1037husterljx pushed a commit to 1037husterljx/Dragonfly2 that referenced this pull request Jul 15, 2022
* feat: update golang version to 1.18.3

Signed-off-by: Gaius <gaius.qi@gmail.com>

* feat: update go mod

Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: update golang version to 1.18.3

Signed-off-by: Gaius <gaius.qi@gmail.com>

* feat: update go mod

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants