Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update namely/protoc-all image version to 1.47_0 #1418

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 29, 2022

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Update namely/protoc-all mage version to 1.47_0.
  • Fix gc package typo.
  • Generate go mock.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 29, 2022
@gaius-qi gaius-qi self-assigned this Jun 29, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 29, 2022 07:39
1037husterljx
1037husterljx previously approved these changes Jun 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1418 (51d2a9d) into main (fa04316) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   44.87%   44.73%   -0.14%     
==========================================
  Files         110      111       +1     
  Lines       10049    10128      +79     
==========================================
+ Hits         4509     4531      +22     
- Misses       5071     5141      +70     
+ Partials      469      456      -13     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 44.73% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clientutil/keepalive.go 0.00% <ø> (ø)
client/config/dynconfig.go 67.74% <ø> (ø)
client/daemon/peer/peertask_manager.go 24.70% <ø> (ø)
client/daemon/peer/peertask_manager_mock.go 33.96% <ø> (ø)
client/daemon/peer/piece_downloader.go 42.18% <ø> (ø)
client/daemon/peer/piece_downloader_mock.go 100.00% <ø> (ø)
client/daemon/proxy/proxy_manager.go 0.00% <ø> (ø)
client/daemon/rpcserver/rpcserver.go 23.84% <ø> (ø)
client/daemon/storage/storage_manager.go 16.69% <ø> (ø)
client/daemon/upload/upload_manager.go 57.14% <ø> (ø)
... and 13 more

@gaius-qi gaius-qi force-pushed the feature/update-protoc-image branch 3 times, most recently from 33cc98d to 91d5f91 Compare June 29, 2022 09:39
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/update-protoc-image branch from 91d5f91 to d5bfab5 Compare June 29, 2022 10:01
@gaius-qi gaius-qi merged commit 6955e7c into main Jun 29, 2022
@gaius-qi gaius-qi deleted the feature/update-protoc-image branch June 29, 2022 10:25
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: update namely/protoc-all image version to 1.47_0

Signed-off-by: Gaius <gaius.qi@gmail.com>

* feat: generate mock file

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants