feat: concurrent multiple pieces back source #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
…ple-pieces-back-source
Codecov Report
@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
+ Coverage 44.28% 44.71% +0.42%
==========================================
Files 113 113
Lines 10198 10373 +175
==========================================
+ Hits 4516 4638 +122
- Misses 5230 5269 +39
- Partials 452 466 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
xujihui1985
approved these changes
Jul 4, 2022
8 tasks
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
* feat: concurrent multiple pieces back source * chore: update http source client Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Ma majinjing3@gmail.com
Description
In some network environments, one tcp connection is limited to very low transfer speed like 2M/s.
Concurrent downloading is very useful for this scenario.
This PR make concurrent multiple pieces download configurable and disabled by default.
We need update documents after merged this PR.
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist