Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: peer.UpdateAt needs to be updated during download process #1818

Merged
merged 1 commit into from Nov 9, 2022
Merged

feat: peer.UpdateAt needs to be updated during download process #1818

merged 1 commit into from Nov 9, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 9, 2022

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • peer.UpdateAt needs to be updated during download process.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi
feat: peer.UpdateAt needs to be updated during download process
71c75b5 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.8 milestone Nov 9, 2022
@gaius-qi gaius-qi self-assigned this Nov 9, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner November 9, 2022 09:24
bigerous
bigerous approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim3ma
jim3ma approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 1c0cfed into main Nov 9, 2022
@gaius-qi gaius-qi deleted the feature/update-at branch November 9, 2022 09:48
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: peer.UpdateAt needs to be updated during download process (#1818)
83ec42c 
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@bigerous bigerous bigerous approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@cndoit18 cndoit18 Awaiting requested review from cndoit18 cndoit18 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
scheduler
Projects
None yet
Milestone
v2.0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaius-qi @jim3ma @bigerous