Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: daemon avoid alway open metadata files #1823

Merged
merged 2 commits into from Nov 11, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Nov 10, 2022

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Fix #1809

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner November 10, 2022 04:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #1823 (bd82d28) into main (bde6496) will decrease coverage by 0.21%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1823      +/-   ##
==========================================
- Coverage   43.79%   43.57%   -0.22%     
==========================================
  Files         128      128              
  Lines       16053    16049       -4     
==========================================
- Hits         7030     6994      -36     
- Misses       8483     8520      +37     
+ Partials      540      535       -5     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 43.57% <37.50%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/storage/storage_manager.go 15.53% <0.00%> (-0.28%) ⬇️
client/daemon/storage/local_storage.go 30.46% <100.00%> (+0.35%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 34.42% <0.00%> (-14.21%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 49.54% <0.00%> (-3.67%) ⬇️
client/daemon/peer/piece_manager.go 53.40% <0.00%> (+0.40%) ⬆️

bigerous
bigerous previously approved these changes Nov 10, 2022
Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 7dc81c0 into main Nov 11, 2022
@gaius-qi gaius-qi deleted the chore/daemon-avoid-alway-open-metadata-file branch November 11, 2022 03:39
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't keep metadataFile open in storageManager
4 participants