Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize peer log #1828

Merged
merged 1 commit into from Nov 14, 2022
Merged

feat: optimize peer log #1828

merged 1 commit into from Nov 14, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Optimize peer log.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.8 milestone Nov 14, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner November 14, 2022 04:18
@gaius-qi gaius-qi self-assigned this Nov 14, 2022
hyy0322
hyy0322 previously approved these changes Nov 14, 2022
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1828 (1e9466a) into main (d72c255) will decrease coverage by 0.63%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
- Coverage   43.82%   43.19%   -0.64%     
==========================================
  Files         128      129       +1     
  Lines       16052    16253     +201     
==========================================
- Hits         7035     7020      -15     
- Misses       8483     8695     +212     
- Partials      534      538       +4     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 43.19% <80.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/peer_manager.go 83.51% <66.66%> (ø)
scheduler/service/service.go 77.19% <66.66%> (ø)
scheduler/resource/host.go 87.69% <100.00%> (ø)
scheduler/resource/peer.go 68.93% <100.00%> (ø)
scheduler/resource/task.go 87.61% <100.00%> (ø)
client/daemon/peer/peertask_piecetask_poller.go 34.42% <0.00%> (-14.21%) ⬇️
client/daemon/rpcserver/rpcserver.go 50.67% <0.00%> (-5.96%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 47.40% <0.00%> (-3.06%) ⬇️
client/daemon/peer/peertask_conductor.go 57.33% <0.00%> (-0.37%) ⬇️
client/dfget/dfget.go 9.65% <0.00%> (-0.27%) ⬇️
... and 5 more

@gaius-qi gaius-qi merged commit 9bc618b into main Nov 14, 2022
@gaius-qi gaius-qi deleted the feature/leave-peer branch November 14, 2022 04:44
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants