Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimize scope size is error #1831

Merged
merged 1 commit into from Nov 14, 2022
Merged

feat: optimize scope size is error #1831

merged 1 commit into from Nov 14, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Optimize scope size is error.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi
feat: optimize scope size is error
2f43726 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.8 milestone Nov 14, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner November 14, 2022 12:58
@gaius-qi gaius-qi self-assigned this Nov 14, 2022
hyy0322
hyy0322 approved these changes Nov 14, 2022
View reviewed changes
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 75925a0 into main Nov 14, 2022
@gaius-qi gaius-qi deleted the feature/scope-size branch November 14, 2022 13:01
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: optimize scope size is error (#1831)
02543c7 
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@hyy0322 hyy0322 hyy0322 approved these changes

@imeoer imeoer Awaiting requested review from imeoer imeoer is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@anjia0532 anjia0532 Awaiting requested review from anjia0532 anjia0532 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@qwtsc qwtsc Awaiting requested review from qwtsc qwtsc is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
scheduler
Projects
None yet
Milestone
v2.0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaius-qi @yxxhero @hyy0322