Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: when dfdaemon disable object storage, dynconfig can't fetch manager #1845

Merged
merged 1 commit into from Nov 21, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • when dfdaemon disable object storage, dynconfig can't fetch manager.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

hyy0322
hyy0322 previously approved these changes Nov 21, 2022
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…ager

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit 87e2fbe into main Nov 21, 2022
@gaius-qi gaius-qi deleted the feature/object-storage-log branch November 21, 2022 09:16
gaius-qi added a commit that referenced this pull request Jun 28, 2023
…ager (#1845)

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants