Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add announcer to dfdameon #1852

Merged
merged 2 commits into from Nov 22, 2022
Merged

feat: add announcer to dfdameon #1852

merged 2 commits into from Nov 22, 2022

Conversation

gaius-qi
Copy link
Member

Description

  • Add announcer to dfdameon.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.8 milestone Nov 22, 2022
@gaius-qi gaius-qi self-assigned this Nov 22, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner November 22, 2022 08:14
@codecov-commenter
Copy link

Codecov Report

Merging #1852 (2a00db3) into main (87e2fbe) will decrease coverage by 0.50%.
The diff coverage is 8.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   43.42%   42.92%   -0.51%     
==========================================
  Files         129      130       +1     
  Lines       16365    16575     +210     
==========================================
+ Hits         7107     7114       +7     
- Misses       8718     8919     +201     
- Partials      540      542       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.92% <8.14%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/peerhost.go 33.07% <ø> (ø)
client/config/peerhost_linux.go 0.00% <0.00%> (ø)
manager/rpcserver/rpcserver.go 3.12% <0.00%> (+<0.01%) ⬆️
scheduler/rpcserver/rpcserver.go 3.17% <0.00%> (ø)
scheduler/service/service.go 74.75% <ø> (+0.10%) ⬆️
client/daemon/announcer/announcer.go 8.61% <8.61%> (ø)
client/daemon/peer/peertask_piecetask_poller.go 48.63% <0.00%> (-2.74%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 49.54% <0.00%> (-0.92%) ⬇️
client/daemon/peer/piece_manager.go 52.99% <0.00%> (-0.41%) ⬇️

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a switch configuration to close this function

@gaius-qi gaius-qi merged commit 92aee94 into main Nov 22, 2022
@gaius-qi gaius-qi deleted the feature/announcer branch November 22, 2022 09:33
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants