Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: clean clippy warnings for macos #1169

Merged
merged 1 commit into from
Mar 23, 2023
Merged

service: clean clippy warnings for macos #1169

merged 1 commit into from
Mar 23, 2023

Conversation

jiangliu
Copy link
Collaborator

Clean clippy warnings for macos.

@anolis-bot
Copy link
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/58449

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@imeoer
Copy link
Collaborator

imeoer commented Mar 22, 2023

It seems still have some errors that need to be resolved:

@jiangliu
service: clean clippy warnings for macos
9904f6d 
Clean clippy warnings for macos.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@jiangliu jiangliu requested a review from a team as a code owner March 22, 2023 04:28
@jiangliu jiangliu requested review from imeoer, changweige and hsiangkao and removed request for a team March 22, 2023 04:28
@jiangliu
Copy link
Collaborator Author

It seems still have some errors that need to be resolved:

Sorry, forgot to commit the actual changes. Updated.

@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/58577

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@imeoer
Copy link
Collaborator

imeoer commented Mar 23, 2023

It works! a successful example: https://github.com/imeoer/image-service/actions/runs/4496915545

@imeoer imeoer merged commit 14c709d into dragonflyoss:master Mar 23, 2023
@jiangliu jiangliu deleted the service-macos-clippy branch March 28, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@changweige changweige Awaiting requested review from changweige changweige is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@hsiangkao hsiangkao Awaiting requested review from hsiangkao hsiangkao is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
anolis_test_pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiangliu @anolis-bot @imeoer