Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: fix benchmark on schedule without cache will panic #1262

Merged
merged 2 commits into from
May 6, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented May 6, 2023

When we can't find the last benchmark result cache, the workfolow will panic.So we should cover the case when we can't find cache.

@Desiki-high Desiki-high requested review from a team as code owners May 6, 2023 03:06
@Desiki-high Desiki-high requested review from liubin, liubogithub and changweige and removed request for a team May 6, 2023 03:06
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #1262 (e518e0b) into master (6d1d56e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   45.06%   45.06%           
=======================================
  Files         126      126           
  Lines       37395    37395           
  Branches    37395    37395           
=======================================
  Hits        16851    16851           
+ Misses      19656    19652    -4     
- Partials      888      892    +4     

see 3 files with indirect coverage changes

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested a review from imeoer May 6, 2023 03:48
@Desiki-high Desiki-high changed the title [WIP]action: fix benchmark on schedule without cache will panic action: fix benchmark on schedule without cache will panic May 6, 2023
@anolis-bot
Copy link
Collaborator

@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71214

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit c2637ee into dragonflyoss:master May 6, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants