misc: reorganize the configuration file of nydusd #1266
Conversation
|
@adamqqqplay , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71565 |
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
=======================================
Coverage 45.06% 45.06%
=======================================
Files 126 126
Lines 37395 37395
Branches 37395 37395
=======================================
+ Hits 16851 16853 +2
+ Misses 19656 19650 -6
- Partials 888 892 +4 |
|
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
adamqqqplay
force-pushed
the
tidy-config-file
branch
from
d30aee0
to
6faad66
Compare
|
@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71575 |
|
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
docs/nydusd.md
Outdated
| "iostats_files": false, | ||
| "enable_xattr": true, | ||
| "fs_prefetch": { | ||
| "enable": true, |
There was a problem hiding this comment.
why do we need prefetch for localfs config?
There was a problem hiding this comment.
@bergwolf I removed this part from config.
adamqqqplay
force-pushed
the
tidy-config-file
branch
from
6faad66
to
2576e29
Compare
|
@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71737 |
|
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
adamqqqplay
force-pushed
the
tidy-config-file
branch
from
2576e29
to
950cbe2
Compare
|
@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71756 |
|
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
docs/nydusd.md
Outdated
| { | ||
| "device": { | ||
| "backend": { | ||
| "type": "localfs", | ||
| "config": { | ||
| "dir": "/path/to/blobs", | ||
| "dir": "/tmp/blobs/" |
There was a problem hiding this comment.
how about using /var/lib/nydus/blobs here?
There was a problem hiding this comment.
Looks good. I fixed it.
| } | ||
| }, | ||
| "cache": { | ||
| "type": "blobcache", | ||
| "config": { |
There was a problem hiding this comment.
why the config field get removed?
There was a problem hiding this comment.
@jiangliu After this commit in containerd/nydus-snapshotter#229, the work_dir field is unnecessary.
There was a problem hiding this comment.
@jiangliu I misunderstood before, this field is still required when there is no snapshotter, it has been fixed now.
1. Move configuration files from docs/samples to misc/configs 2. Fix incomplete configuration in docs/nydusd.md 3. Update outdated nydusd-config.json from nydus-snapshotter repo Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
adamqqqplay
force-pushed
the
tidy-config-file
branch
from
950cbe2
to
c54f441
Compare
|
@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71809 |
|
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@adamqqqplay , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/71819 |
|
@adamqqqplay , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Fix: #1180