Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nydusify can dump metrics created by converter #1272

Merged
merged 2 commits into from
May 15, 2023

Conversation

Desiki-high
Copy link
Member

We are introducing a new arg called "output-json" that will allow us to save the metrics generated by convert. This will enable us to successfully implement #1263 through nydusify.

For additional information, please see goharbor/acceleration-service#133.

@Desiki-high Desiki-high requested a review from a team as a code owner May 11, 2023 09:19
@Desiki-high Desiki-high requested review from liubin, jiangliu and luodw and removed request for a team May 11, 2023 09:19
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1272 (841920f) into master (db0cc41) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   45.06%   45.05%   -0.01%     
==========================================
  Files         126      126              
  Lines       37395    37395              
  Branches    37395    37395              
==========================================
- Hits        16852    16850       -2     
- Misses      19655    19657       +2     
  Partials      888      888              

see 3 files with indirect coverage changes

@Desiki-high Desiki-high force-pushed the ci-convert-imagesize branch 2 times, most recently from 34ccdfc to 893d4b3 Compare May 12, 2023 07:07
@Desiki-high Desiki-high changed the title [WIP]feat: nydusify can dump metrics created by converter feat: nydusify can dump metrics created by converter May 12, 2023
@anolis-bot
Copy link
Collaborator

@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72272

@Desiki-high
Copy link
Member Author

Desiki-high commented May 12, 2023

The output json like this:

{
    "SourceImageSize": 6743297,
    "TargetImageSize": 6858694,
    "SourcePullElapsed": 6671762202,
    "ConversionElapsed": 249787117,
    "TargetPushElapsed": 176941854
}

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72281

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@Desiki-high
Copy link
Member Author

/retest

@anolis-bot
Copy link
Collaborator

@Desiki-high , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72298

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72407

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

contrib/nydusify/cmd/nydusify.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/converter/metric.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/converter/metric.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/converter/metric.go Show resolved Hide resolved
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
During convert, we can collect the metric: image size and convert time, etc.
Nydusify can dump the metric to local file if user needs.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72753

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@imeoer imeoer merged commit c7c9fad into dragonflyoss:master May 15, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants