Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: convert ci can show the metrics collected during conversion #1279

Merged
merged 2 commits into from
May 17, 2023
Merged

action: convert ci can show the metrics collected during conversion #1279

merged 2 commits into from
May 17, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented May 16, 2023 •
edited

Changes:

  1. let users specify the file path by output-json, otherwise the json file will be cleared in work directory.
  2. We can show the metrics collected during conversion in convert ci, you can see the preview.

Related PR: #1272.
Resolves #1263.

@Desiki-high Desiki-high requested review from a team as code owners May 16, 2023 06:27
@Desiki-high Desiki-high requested review from liubogithub, changweige and hsiangkao and removed request for a team May 16, 2023 06:27
@anolis-bot
Copy link
Collaborator

@Desiki-high , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72908

@codecov
Copy link

codecov bot commented May 16, 2023 •
edited

Codecov Report

Merging #1279 (404941d) into master (0a88fda) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1279   +/-   ##
=======================================
  Coverage   45.07%   45.08%           
=======================================
  Files         126      126           
  Lines       37403    37403           
  Branches    37403    37403           
=======================================
+ Hits        16861    16862    +1     
+ Misses      19656    19649    -7     
- Partials      886      892    +6

see 3 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72948

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/73564

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/73571

@anolis-bot
Copy link
Collaborator

@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/73573

@Desiki-high Desiki-high requested a review from imeoer May 17, 2023 02:49
@Desiki-high
fix: nydusify save metric to specify the file path
dfc054a 
We should not save metrics in work directory, otherwise it will be cleared.
We need use to specify the file path, so just change output-json to string opt.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high
action: convert ci show metrics during conversion
404941d 
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/73586

@Desiki-high Desiki-high requested a review from imeoer May 17, 2023 03:03
imeoer
imeoer approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 5f76e8b into dragonflyoss:master May 17, 2023
24 checks passed
@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@liubogithub liubogithub Awaiting requested review from liubogithub liubogithub is a code owner automatically assigned from dragonflyoss/nydus-maintainers

@changweige changweige Awaiting requested review from changweige changweige is a code owner automatically assigned from dragonflyoss/nydus-maintainers

@hsiangkao hsiangkao Awaiting requested review from hsiangkao hsiangkao is a code owner automatically assigned from dragonflyoss/nydus-maintainers

Assignees
No one assigned
Labels
anolis_test_fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: count the image size in Convert & Check Images
3 participants
@Desiki-high @anolis-bot @imeoer