Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: fix fuse-backend-rs dependency in cargo.toml #1292

Merged
merged 1 commit into from
May 19, 2023

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

#1283

Details

The previous changes only upgraded the value in cargo.lock, we should also upgrade cargo.toml.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@adamqqqplay adamqqqplay requested a review from a team as a code owner May 19, 2023 04:02
@adamqqqplay adamqqqplay requested review from bergwolf, liubin and hsiangkao and removed request for a team May 19, 2023 04:02
@anolis-bot
Copy link
Collaborator

@adamqqqplay , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74193

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1292 (b809ad5) into master (faa4116) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1292   +/-   ##
=======================================
  Coverage   45.07%   45.08%           
=======================================
  Files         126      126           
  Lines       37403    37402    -1     
  Branches    37403    37402    -1     
=======================================
+ Hits        16859    16862    +3     
+ Misses      19656    19649    -7     
- Partials      888      891    +3     
Impacted Files Coverage Δ
blobfs/src/lib.rs 0.72% <ø> (ø)
src/bin/nydus-image/main.rs 40.91% <ø> (ø)
src/bin/nydusd/main.rs 0.19% <0.00%> (ø)
src/logger.rs 51.82% <ø> (ø)
src/signal.rs 0.00% <ø> (ø)
src/lib.rs 52.50% <71.42%> (-5.84%) ⬇️

... and 1 file with indirect coverage changes

@liubogithub
Copy link
Collaborator

Can you please also put the following detail in patch commit log?
The previous changes only upgraded the value in cargo.lock, we should also upgrade cargo.toml.

The previous changes dragonflyoss#1283 only upgraded the values in cargo.lock,
we should also upgrade cargo.toml.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74196

@adamqqqplay
Copy link
Member Author

Can you please also put the following detail in patch commit log? The previous changes only upgraded the value in cargo.lock, we should also upgrade cargo.toml.

OK, fixed.

@liubogithub liubogithub merged commit 197795d into dragonflyoss:master May 19, 2023
24 checks passed
@adamqqqplay adamqqqplay deleted the fix-fuse-backend-rs branch May 19, 2023 06:08
@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants