Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken integration test for v5 image #1297

Merged
merged 2 commits into from
May 22, 2023

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

#1150

Details

Integration Test always fails after March 15, 2023, most likely because of the #1150 change.

Since the Integration Test written by pytest will be deprecated in the future, we have fixed it with some temporary solutions. The latest successful test results are in this page.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay adamqqqplay requested a review from imeoer May 22, 2023 11:29
@adamqqqplay adamqqqplay requested review from a team as code owners May 22, 2023 11:29
@adamqqqplay adamqqqplay requested review from liubogithub and changweige and removed request for a team May 22, 2023 11:29
@anolis-bot
Copy link
Collaborator

@adamqqqplay , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/74610

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #1297 (2b49c96) into master (5879c91) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1297   +/-   ##
=======================================
  Coverage   45.70%   45.71%           
=======================================
  Files         124      124           
  Lines       36884    36884           
  Branches    36884    36884           
=======================================
+ Hits        16857    16860    +3     
+ Misses      19138    19133    -5     
- Partials      889      891    +2     

see 5 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit 17fd41c into dragonflyoss:master May 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants