Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: correctly generate nid for v6 inodes #1304

Merged
merged 2 commits into from
May 28, 2023

Conversation

jiangliu
Copy link
Collaborator

The nid is not actually used yet, but we should still generate it with correct value.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@jiangliu jiangliu requested a review from a team as a code owner May 27, 2023 07:47
@jiangliu jiangliu requested review from bergwolf, liubin and hsiangkao and removed request for a team May 27, 2023 07:47
@anolis-bot
Copy link
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/75716

The `nid` is not actually used yet, but we should still generate it
with correct value.

Fixes: dragonflyoss#1301

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #1304 (ccdd579) into master (23c6110) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
- Coverage   45.93%   45.91%   -0.02%     
==========================================
  Files         123      123              
  Lines       37028    37031       +3     
  Branches    37028    37031       +3     
==========================================
- Hits        17009    17004       -5     
- Misses      19125    19130       +5     
- Partials      894      897       +3     
Impacted Files Coverage Δ
rafs/src/builder/core/bootstrap.rs 72.84% <0.00%> (ø)
rafs/src/builder/core/v6.rs 32.45% <0.00%> (-0.12%) ⬇️
rafs/src/builder/stargz.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Fix a compilation failure on macos.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/75717

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@imeoer imeoer merged commit 08c3d0f into dragonflyoss:master May 28, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants