Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rafs: Add missing prefix of hex #1309

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

liubogithub
Copy link
Collaborator

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Without hex prefix, it confuses me a little bit when debugging flags problems.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Without hex prefix, it confuses me a little bit when debugging flags problems.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
@liubogithub liubogithub requested a review from a team as a code owner June 2, 2023 04:30
@liubogithub liubogithub requested review from bergwolf, liubin and hsiangkao and removed request for a team June 2, 2023 04:30
@anolis-bot
Copy link
Collaborator

@liubogithub , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/76589

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #1309 (ce009a0) into master (a88a2e8) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
- Coverage   45.91%   45.90%   -0.02%     
==========================================
  Files         123      123              
  Lines       37033    37033              
  Branches    37033    37033              
==========================================
- Hits        17005    16999       -6     
- Misses      19136    19139       +3     
- Partials      892      895       +3     
Impacted Files Coverage Δ
rafs/src/metadata/md_v5.rs 15.38% <0.00%> (ø)
rafs/src/metadata/md_v6.rs 57.22% <0.00%> (ø)

... and 4 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@liubogithub , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit 5b15922 into dragonflyoss:master Jun 2, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants