fix: merge io from same blob panic #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging io from same blob with different id, assertion breaks. The images without blob deduplication suffers from it. This pr removes the assertion that requires merging in same blob index. By design, it makes sense, because different blob layer may share same blob file. A continuous read from same blob for different layer is helpful for performance. Signed-off-by: 泰友 <cuichengxu.ccx@antgroup.com>
ccx1024cc
requested review from
bergwolf,
jiangliu and
changweige
and removed request for
a team
|
@ccx1024cc , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83046 |
|
@ccx1024cc , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83047 |
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
+ Coverage 45.69% 45.79% +0.09%
==========================================
Files 123 123
Lines 37287 37339 +52
Branches 37287 37339 +52
==========================================
+ Hits 17040 17099 +59
+ Misses 19349 19341 -8
- Partials 898 899 +1
|
|
@ccx1024cc , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
adamqqqplay
approved these changes
Jul 6, 2023
jiangliu
approved these changes
Jul 6, 2023
|
@ccx1024cc , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
||||||
This was referenced Jul 11, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When merging io from same blob with different id, assertion breaks. The images without blob deduplication suffer from it.
This pr removes the assertion that requires merging in same blob index. By design, it makes sense, because different blob layer may share same blob file. A continuous read from same blob for different layer is helpful for performance.
Types of changes
Checklist