Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: allow to build debug version nydusd #1369

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

bergwolf
Copy link
Member

Relevant Issue (if applicable)

none.

Details

We still build the release version by default, but make sure that make build only generates a debug version nydusd.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

We still build release version by default, but make sure that `make build`
only generates a debug version nydusd.

Signed-off-by: Peng Tao <bergwolf@hyper.sh>
@bergwolf bergwolf requested a review from a team as a code owner July 12, 2023 04:31
@bergwolf bergwolf requested review from liubogithub, imeoer and hsiangkao and removed request for a team July 12, 2023 04:31
@anolis-bot
Copy link
Collaborator

@bergwolf , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84209

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1369 (ae58c3b) into master (c8a39c8) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
- Coverage   46.01%   45.94%   -0.07%     
==========================================
  Files         122      122              
  Lines       37807    37807              
  Branches    37807    37807              
==========================================
- Hits        17396    17372      -24     
- Misses      19502    19525      +23     
- Partials      909      910       +1     

see 6 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@bergwolf , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@imeoer imeoer merged commit 3de2025 into dragonflyoss:master Jul 12, 2023
24 checks passed
@bergwolf bergwolf deleted the github/makefile branch July 12, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants