Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change a new nydus image for ci test #1371

Merged
merged 1 commit into from
Jul 13, 2023
Merged

change a new nydus image for ci test #1371

merged 1 commit into from
Jul 13, 2023

Conversation

yqleng1987
Copy link
Contributor

The network is not stable when pulling the old image, which may result in ci test failure, so use the new image instead.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@yqleng1987 yqleng1987 requested a review from a team as a code owner July 12, 2023 07:10
@yqleng1987 yqleng1987 requested review from liubin, luodw and adamqqqplay and removed request for a team July 12, 2023 07:10
@anolis-bot
Copy link
Collaborator

@yqleng1987 , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84231

@anolis-bot
Copy link
Collaborator

@yqleng1987 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@@ -1,7 +1,7 @@
load "${BATS_TEST_DIRNAME}/common_tests.sh"

setup() {
nydus_rafs_image="nydus-anolis-registry.cn-hangzhou.cr.aliyuncs.com/nydus_test/bldlinux:v0.1-rafs-v6-lz4"
nydus_rafs_image="docker.io/hsiangkao/bldlinux:v0.1-rafs-v6-lz4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am worried about the QPS limitation from dockerhub which can break the CI test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, the test machine is located in Europe.
Secondly, the other 2 test cases below use the image in dockerhub, which is more stable than this test case which uses the image in hangzhou, based on the previous testing history.
https://github.com/dragonflyoss/image-service/blob/master/tests/bats/run_container_with_rafs.bats
https://github.com/dragonflyoss/image-service/blob/master/tests/bats/run_container_with_zran.bats

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yqleng1987 I just uploaded a image to the github repository: ghcr.io/dragonflyoss/image-service/bldlinux:v0.1-rafs-v6-lz4, could you try it to be able to use in CI?

The network is not stable when pulling the old image, which may result in
ci test failure, so use the new image instead.

Signed-off-by: Yiqun Leng <yqleng@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@yqleng1987 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/84307

@anolis-bot
Copy link
Collaborator

@yqleng1987 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergwolf bergwolf merged commit 6b61aad into dragonflyoss:stable/v2.2 Jul 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants