Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify: introduce copy subcommand #1380

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Jul 20, 2023

nydusify copy copies an image from source registry to target registry, it also supports to specify a backend storage.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer imeoer requested a review from a team as a code owner July 20, 2023 11:31
@imeoer imeoer requested review from bergwolf, jiangliu and changweige and removed request for a team July 20, 2023 11:31
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1380 (f78e864) into master (156ba6a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
- Coverage   46.45%   46.44%   -0.02%     
==========================================
  Files         123      123              
  Lines       38602    38602              
  Branches    38602    38602              
==========================================
- Hits        17934    17928       -6     
- Misses      19697    19702       +5     
- Partials      971      972       +1     

see 3 files with indirect coverage changes

@imeoer imeoer force-pushed the nydusify-copy branch 4 times, most recently from cfb2159 to 0c6599f Compare July 23, 2023 21:42
@imeoer imeoer force-pushed the nydusify-copy branch 2 times, most recently from 9770d26 to ddaac54 Compare August 21, 2023 10:43
@imeoer imeoer changed the title [WIP] nydusify: introduce copy subcommand nydusify: introduce copy subcommand Aug 21, 2023
@imeoer imeoer force-pushed the nydusify-copy branch 5 times, most recently from f845e32 to f587b68 Compare August 23, 2023 09:23
Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update nydusify copy usage in docs/nydusify.md?

imeoer and others added 2 commits August 24, 2023 09:06
`nydusify copy` copies an image from source registry to target
registry, it also supports to specify a source backend storage.

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@anolis-bot
Copy link
Collaborator

@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/89872

@imeoer
Copy link
Collaborator Author

imeoer commented Aug 24, 2023

Could you please update nydusify copy usage in docs/nydusify.md?

Thanks for the comment, added doc.

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM

@imeoer imeoer merged commit d9f8fa9 into dragonflyoss:master Aug 25, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants