nydusify: support --with-referrer option #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
requested review from
bergwolf,
jiangliu and
changweige
and removed request for
a team
|
@imeoer , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87910 |
|
@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87913 |
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
- Coverage 46.32% 46.31% -0.01%
==========================================
Files 122 122
Lines 38071 38071
Branches 38071 38071
==========================================
- Hits 17635 17632 -3
- Misses 19512 19513 +1
- Partials 924 926 +2 |
Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
With this option, we can track all nydus images associated with an OCI image. For example, in Harbor we can cascade to show nydus images linked to an OCI image, deleting the OCI image can also delete the corresponding nydus images. At runtime, nydus snapshotter can also automatically upgrade an OCI image run to nydus image. Prior to this PR, we had enabled this feature by default. However, it is now known that Docker Hub does not yet support Referrer. Therefore, adding this option to disable this feature by default, to ensure broad compatibility with various image registries. Fix dragonflyoss#1363. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
fix-nydusify-subject
branch
from
c040c7d
to
500b904
Compare
|
@imeoer , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87927 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
approved these changes
Aug 1, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#1363
Details
With this option, we can track all nydus images associated with
an OCI image. For example, in Harbor we can cascade to show nydus
images linked to an OCI image, deleting the OCI image can also delete
the corresponding nydus images. At runtime, nydus snapshotter can also
automatically upgrade an OCI image run to nydus image.
Prior to this PR, we had enabled this feature by default. However,
it is now known that Docker Hub does not yet support Referrer.
Therefore, adding this option to disable this feature by default,
to ensure broad compatibility with various image registries.
Fix #1363.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.