[backport stable/v2.2] storage: simplify mirror implementation #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nydusd uses a registry backend which generates a surge of blob requests without auth tokens on initial startup. This caused mirror backends (e.g. dragonfly) to process very slowly, the commit fixes this problem. It implements waiting for the first blob request to complete before making other blob requests, this ensures the first request caches a valid registry auth token, and subsequent concurrent blob requests can reuse the cached token. This change is worthwhile to reduce concurrent token requests, it also makes the behavior consistent with containerd, which first requests the image manifest and caches the token before concurrently requesting blobs. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
requested review from
liubin,
adamqqqplay and
hsiangkao
and removed request for
a team
The auth_through option adds user burden to configure the mirror and understand its meaning, and since we have optimized handling of concurrent token requests, this option can now be removed. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
- Make registry mirror log pretty; - Adjust token refresh interval automatically; Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
stable/v2.2-backport
branch
from
bed60c6
to
cca1ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
Backport PR #1375 to stable/v2.2
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.