Add seekable method for TarReader use to determine whether the current reader supports seek #1411
Conversation
zyfjeff
requested review from
bergwolf,
liubin and
gaius-qi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
=======================================
Coverage 46.43% 46.43%
=======================================
Files 123 123
Lines 38644 38655 +11
Branches 38644 38655 +11
=======================================
+ Hits 17943 17951 +8
- Misses 19727 19730 +3
Partials 974 974
|
|
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90733 |
builder/src/tarball.rs
Outdated
| TarReader::BufReaderInfoSeekable(b) => b.seek(pos), | ||
| _ => Err(enosys!("seek() not supported!")), | ||
| TarReader::File(f) => { | ||
| debug_assert!(seekable); |
There was a problem hiding this comment.
We do not recommend using debug_assert!, as this may cause inconsistent binary behavior between debug and release builds (although this would not happen here).
…t reader supports seek Signed-off-by: zyfjeff <zyfjeff@linux.alibaba.com>
|
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90741 |
|
retest |
|
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90757 |
|
@zyfjeff , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90760 |
…t reader supports seek Signed-off-by: zyfjeff <zyfjeff@linux.alibaba.com>
Relevant Issue (if applicable)
#1410
Details
Add seekable method for TarReader use to determine whether the current reader supports seek
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.