nydus-overlayfs: filter option "io.katacontainers.volume" #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
requested review from
liubogithub,
imeoer and
adamqqqplay
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
- Coverage 46.45% 46.44% -0.02%
==========================================
Files 123 123
Lines 38643 38643
Branches 38643 38643
==========================================
- Hits 17952 17947 -5
- Misses 19718 19722 +4
- Partials 973 974 +1 |
imeoer
reviewed
Sep 6, 2023
| @@ -13,7 +13,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| extraOptionKey = "extraoption=" | |||
| extraOptionKey = "extraoption=" | |||
| kataVolumeOptionKey = "io.katacontainers.volume=" | |||
There was a problem hiding this comment.
Can add some comments to explain why we ignore the option key here?
There was a problem hiding this comment.
This is to make use of the KataVirtualVolume abstraction from
https://github.com/kata-containers/kata-containers/blob/main/src/libs/kata-types/src/mount.rs#L233
jiangliu
force-pushed
the
kata-volume
branch
from
ddc68a5
to
554fabc
Compare
Filter mount option "io.katacontainers.volume", which is a superset of "extraoptions". Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
jiangliu
force-pushed
the
kata-volume
branch
from
554fabc
to
9a6d3a9
Compare
imeoer
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter mount option "io.katacontainers.volume", which is a superset of "extraoptions".
Types of changes
Checklist
Go over all the following points, and put an
xin all the boxes that apply.