Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: update test branch for integration #1422

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Sep 12, 2023

We are focusing on v2.2 maintenance, let's we change the test branch
from `stable/v2.1` to `stable/v2.2`.

It also fix the broken integration test:
https://github.com/dragonflyoss/image-service/actions/runs/6153232407

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

We are focusing on v2.2 maintenance, let's we change the test branch
from `stable/v2.1` to `stable/v2.2`.

It also fix the broken integration test:
https://github.com/dragonflyoss/image-service/actions/runs/6153232407

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@imeoer imeoer requested a review from a team as a code owner September 12, 2023 06:42
@imeoer imeoer requested review from bergwolf, gaius-qi and changweige and removed request for a team September 12, 2023 06:42
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #1422 (0f61da0) into master (a35e634) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
- Coverage   46.45%   46.44%   -0.02%     
==========================================
  Files         123      123              
  Lines       38643    38643              
  Branches    38643    38643              
==========================================
- Hits        17951    17947       -4     
- Misses      19721    19722       +1     
- Partials      971      974       +3     

see 3 files with indirect coverage changes

Copy link
Member

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Desiki-high Desiki-high merged commit d2fcfcd into dragonflyoss:master Sep 13, 2023
24 checks passed
@adamqqqplay
Copy link
Member

@imeoer Maybe we could release a new version on the stable/v2.1 branch?

@imeoer
Copy link
Collaborator Author

imeoer commented Sep 13, 2023

@imeoer Maybe we could release a new version on the stable/v2.1 branch?

We are focusing on v2.2 maintenance, do we still need to release a new v2.1.x ?

@adamqqqplay
Copy link
Member

@imeoer Maybe we could release a new version on the stable/v2.1 branch?

We are focusing on v2.2 maintenance, do we still need to release a new v2.1.x ?

@imeoer It seems that there are some new changes added to the stable/v2.1 branch since v2.1.6, and it may be necessary to release a final version for them.

@imeoer
Copy link
Collaborator Author

imeoer commented Sep 15, 2023

@adamqqqplay Ok, we can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants