storage: fix auth compatibility for registry backend

[lihuahua123]

Relevant Issue (if applicable)

Details

fix auth compatibility for registry backend:
Due to the different implementations of various image registries, auth requests may use the GET or POST methods.
In the previous way, it just use 'GET' method, and in the pr, we fix it advanced, it can use and cache the GET or POST methods.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

• I have updated the documentation accordingly.
• I have added tests to cover my changes.

[imeoer]

Hi @lihuahua123 please add the detailed commit message, and the commit title better be like storage: fix auth compatibility for registry backend.

[codecov]

Codecov Report

Merging #1425 (9276471) into master (d2fcfcd) will decrease coverage by 0.07%.
Report is 7 commits behind head on master.
The diff coverage is 8.57%.

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   46.46%   46.40%   -0.07%     
==========================================
  Files         123      123              
  Lines       38643    38745     +102     
  Branches    38643    38745     +102     
==========================================
+ Hits        17954    17978      +24     
- Misses      19716    19794      +78     
  Partials      973      973              

Files	Coverage Δ
storage/src/backend/registry.rs	32.94% <8.57%> (-1.27%)	⬇️

... and 12 files with indirect coverage changes

[imeoer]

How about:

// Cache for the HTTP method when getting auth, possible values: "get", "post".
// Due to the different implementations of various image registries, auth requests
// may use the GET or POST methods, we need to cache the method after the
// fallback, so it can be reused next time and reduce an unnecessary request.
cached_auth_using_http_get: HashCache,

And can we make it as HashCache<bool> ?

struct HashCache(RwLock<HashMap<String, T>>);

[lihuahua123]

In the context ,HashCache is implemented as
struct HashCache(RwLock<HashMap<String, String>>);
if we make it as' HashCache ', it need implement another logic

[imeoer]

I mean the generic type https://doc.rust-lang.org/rust-by-example/generics.html

[lihuahua123]

I have resolve it with changing the implemention of struct HashCache(RwLock<HashMap<String, String>>); to struct HashCache<T>(RwLock<HashMap<String, T>>);.

[lihuahua123]

It is reused as follows.

    // Cache for the HTTP method when getting auth, possible values: "get", "post".
    // Due to the different implementations of various image registries, auth requests
    // may use the GET or POST methods, we need to cache the method after the
    // fallback, so it can be reused next time and reduce an unnecessary request.
    cached_auth_using_http_get: HashCache<bool>,
    // Cache 30X redirect url
    // Example: RwLock<HashMap<"<blob_id>", "<redirected_url>">>
    cached_redirect: HashCache<String>,

[imeoer]

Should also update the comment.

[lihuahua123]

Ok！

[imeoer]

LGTM, thanks!