nydus-image：optimize chunkdict save #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslinwang
requested review from
jiangliu,
luodw and
adamqqqplay
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
==========================================
- Coverage 46.46% 46.44% -0.02%
==========================================
Files 123 123
Lines 38643 38640 -3
Branches 38643 38640 -3
==========================================
- Hits 17954 17947 -7
- Misses 19716 19719 +3
- Partials 973 974 +1
|
imeoer
reviewed
Sep 21, 2023
Refactor the Deduplicate implementation to only initialize config when inserting chunk data. Simplify code for better maintainability. Signed-off-by: Lin Wang <l.wang@mail.dlut.edu.cn>
cslinwang
force-pushed
the
nydus-chunkdict-optimize
branch
from
8054586
to
d28bbb5
Compare
imeoer
approved these changes
Sep 22, 2023
An-DJ
reviewed
Sep 25, 2023
| @@ -399,7 +398,7 @@ fn prepare_cmd_args(bti_string: &'static str) -> App { | |||
| ) | |||
| .arg(arg_output_json.clone()) | |||
| ) | |||
| ); | |||
| ); | |||
There was a problem hiding this comment.
Can't believe that cargo fmt didn't find this...
There was a problem hiding this comment.
It seems cargo fmt is broken from L164. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Refactor the Deduplicate implementation to only
initialize config when inserting chunk data.
Simplify code for better maintainability.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.