Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't need to access backend when all filecache ready #1414

Closed
zyfjeff opened this issue Aug 30, 2023 · 1 comment
Closed

don't need to access backend when all filecache ready #1414

zyfjeff opened this issue Aug 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@zyfjeff
Copy link
Contributor

zyfjeff commented Aug 30, 2023

Version of nydus being used (nydusd --version)

Version: v2.2.2-14-g49359290
Git Commit: 4935929
Build Time: 2023-08-24T12:22:25.260520367Z
Profile: release
Rustc: rustc 1.66.1 (90743e729 2023-01-10)

Details about issue

After starting with filecache, the cache has already been downloaded and ready, in which case we should need to support offline startup nydusd, even if you can't access the backend

The current implementation always checks whether the corresponding blob exists at startup time.

        let reader = mgr
            .backend
            .get_reader(&blob_id)
            .map_err(|e| eio!(format!("failed to get reader for blob {}, {}", blob_id, e)))?;
        let blob_meta_reader = if is_separate_meta {
            mgr.backend.get_reader(&blob_meta_id).map_err(|e| {
                eio!(format!(
                    "failed to get reader for blob.meta {}, {}",
                    blob_id, e
                ))
            })?
        } else {
            reader.clone()
        };
@adamqqqplay adamqqqplay added the enhancement New feature or request label Oct 28, 2023
@imeoer
Copy link
Collaborator

imeoer commented Jun 18, 2024

This requirement seems to be out of date, please reopen it if necessary.

@imeoer imeoer closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants