Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CronExpression::factory() in favor of __construct() #56

Closed
dragonmantank opened this issue Oct 11, 2019 · 0 comments · Fixed by #99
Closed

Deprecate CronExpression::factory() in favor of __construct() #56

dragonmantank opened this issue Oct 11, 2019 · 0 comments · Fixed by #99

Comments

@dragonmantank
Copy link
Owner

As pointed out in #49 , there is no real reason to keep both a factory and a construct method with how this object is built. We should deprecate factory() and move that logic into the constructor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depreceate CronExpression::factory and remove references DerekCresswell/cron-expression
1 participant
@dragonmantank