New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly utilise interfaces #97

Closed

DerekCresswell opened this issue Nov 6, 2020 · 0 comments · Fixed by #98

DerekCresswell commented Nov 6, 2020

The constructor for CronExpression currently takes a FieldFactory, not FieldFactoryInterface.

The FieldFactoryInterface::getField needs to return FieldInterface.

I'm trying to extend this library and this is a problem for me. I will provide a PR for this.

DerekCresswell mentioned this issue

Allow proper usage of interfaces #98

Merged

dragonmantank closed this as completed in #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment