Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to append to rules/macros #277

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Add ability to append to rules/macros #277

merged 1 commit into from
Sep 25, 2017

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented Sep 23, 2017

Add the ability to append to rules/macros, like we already do with
lists. For rules/macros, if the object has an append: true key, the
condition value is appended to the condition of an existing rule/macro
with the same name.

Like lists, it's an error to specify append: true without there being an
existing rule/macro.

Also add tests that test the same kind of things we did for lists:

  • That append: true really does append
  • That append: false overwrites the rule/macro
  • That it's an error to append with a prior rule/macro existing.

Add the ability to append to rules/macros, like we already do with
lists. For rules/macros, if the object has an append: true key, the
condition value is appended to the condition of an existing rule/macro
with the same name.

Like lists, it's an error to specify append: true without there being an
existing rule/macro.

Also add tests that test the same kind of things we did for lists:
 - That append: true really does append
 - That append: false overwrites the rule/macro
 - That it's an error to append with a prior rule/macro existing.
@mstemm mstemm merged commit c41bcbd into dev Sep 25, 2017
@mstemm mstemm deleted the append-macros-rules branch September 25, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant