Add TBB dependency #412
Merged
Add TBB dependency #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
requested changes
Sep 6, 2018
CMakeLists.txt
Outdated
| set(TBB_INCLUDE "${TBB_SRC}/include/") | ||
| set(TBB_LIB "${TBB_SRC}/build/lib_release/libtbb.a") | ||
| ExternalProject_Add(tbb | ||
| URL "https://github.com/01org/tbb/archive/2018_U5.tar.gz" # FIXME |
There was a problem hiding this comment.
I will kindly point out the FIXME here. I think you want to copy this to downloads.draios.com right?
There was a problem hiding this comment.
Yup (I also highlighted it in the PR description)
mstemm
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falco counterpart of draios/sysdig#1213.
As for the sysdig PR, once the PR is approved the download URL for TBB has to be changed to point under
download.draios.com.