Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of "format" for numbers less than 1 #3

Open
firasm opened this issue May 26, 2021 · 2 comments
Open

Better handling of "format" for numbers less than 1 #3

firasm opened this issue May 26, 2021 · 2 comments

Comments

@firasm
Copy link

firasm commented May 26, 2021

Currently the "thousands separator" is also added to numbers that are less than 1.

If I run sigfig.round(-0.34344405,sigfigs=4, format = 'English'), I would expect to get the result '-0.3434', but instead I get '0.343,4' which I suppose isn't "wrong" but looks funny.

Workaround: str(sigfig.round(-0.34344405,sigfigs=4, format = 'English')) to get '-0.3434'

@MikeBusuttil
Copy link
Collaborator

thanks for pointing this out @firasm . It looks like your opinion matches the standard (as laid out at https://www.grammar-monster.com/lessons/commas_with_numbers.htm ). I think we'll have to add to the roadmap the ability to remove separators on the right of the decimal place.

Do you think it should be currently listed as a "feature request" or "known issue"? I'm leaning towards feature request

@firasm
Copy link
Author

firasm commented May 28, 2021

hmm before I read your link, I would've said bug, but after finding out that this is expected behaviour outside of North America, definitely leaning towards a a feature request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants