Open in browser

[jtagcat]

Feature request: Preview files in the browser when clicking on it in a list.

This can be done by using Content-Disposition: inline; instead of Content-Disposition: attachment;.

The feature could include a file extension whitelist, but doesn't have to, since the browser downloads files it can't display anyway.

Files can still be directly downloaded from the menu.

[drakkan]

Hello,

thank you for your suggestion.

What's wrong with the preview icon?

Do you have trouble with a particular type of file that the browser can display and SFTPGo doesn't display the icon for preview?

[jtagcat]

I don't see the preview icon anywhere: pdf, mp3, jpg, flac files.

In my opinion, if I click on the filename, it should open a preview, the download being the secondary action instead.

[jtagcat]

The preview icon is not available for shared links.

[alexitx]

Please make an option, at least for public shares. It will be really useful. Currently, images, video, documents and other files readable by browsers cannot be previewed and instead begin to download. Proposal - a setting, such as Direct download: true/false when creating a share, or available globally which will disregard file extensions and always set the Content-Disposition: inline header for all files.

Edit: after a quick look, I see a function downloadFromShare, which I assume handles downloading files from public shares, but ignores the inline parameter, and a different function downloadBrowsableSharedFile, which seems to be used only in the REST API, but checks for the inline parameter and, if present, doesn't set Content-Disposition: attachment. Can this be done in a similar way for downloading from the web client instead of the API?

[drakkan]

please try sending a PR. We will discuss further implementation details once we have a working (and XSS safe) PR. Thank you

[alexitx]

I would love to, but I have no experience in Go. If someone decides to open a PR, I can help with testing.