Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ACL permission drop down truncated #1541

Closed
2 tasks done
mr-manuel opened this issue Feb 12, 2024 · 8 comments
Closed
2 tasks done

[Bug]: ACL permission drop down truncated #1541

mr-manuel opened this issue Feb 12, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@mr-manuel
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration issue.
  • This issue is not already reported on Github (I've searched it).

Bug description

If the drop down menu of the ACL permissions is opened when located in the lower section of the page, the list is truncated.
grafik

When the drop down menu is located in the upper section of the page, the list is displayed correctly.
grafik

Steps to reproduce

  1. Open the admin page
  2. Go to Users -> Edit user -> ACLs.
  3. Make sure you don't see the "Per-directory pattern restrictions" modal yet.
  4. Click on one of the drop down menus of the ACLs section.
  5. Now you see the cut off drop down menu. Once a scrollbar was shown, but all other times not.

Expected behavior

The drop down menu should be visible.

SFTPGo version

SFTPGo 2.5.6-a6a92f0d-2023-12-18T17:48:48Z +metrics +azblob +gcs +s3 +bolt +mysql +pgsql +sqlite +unixcrypt +portable

Data provider

Local

Installation method

Community Docker image

Configuration

Not relevant

Relevant log output

No response

What are you using SFTPGo for?

Private user, home usecase (home backup/VPS)

Additional info

Tested with Firefox 122.0.1 and Microsoft Edge 121.0.2277.112.

@mr-manuel mr-manuel added the bug Something isn't working label Feb 12, 2024
@drakkan
Copy link
Owner

drakkan commented Feb 12, 2024

Hello,

this is a known issue, please try the new UI added to the development version, it should be fixed. Thank you

@mr-manuel
Copy link
Author

Thans for your answer. I will try the edge version then.

Very neat the new GUI! But no entries did load. User and Groups pages where forever loading. I have to check that with a bit more time. I will report then back.

@drakkan
Copy link
Owner

drakkan commented Feb 12, 2024

Thans for your answer. I will try the edge version then.

Very neat the new GUI! But no entries did load. User and Groups pages where forever loading. I have to check that with a bit more time. I will report then back.

I guess this is related to some caching issue or to the translation system. Please take a look at the web developer console to understand the issue, maybe you use an unsupported language, English should be used in this case but I haven't tested using a browser with no english or italian language.

@mr-manuel
Copy link
Author

I cleared the cache and checked with developer tools. The browser language is german. With english or italian it works indeed. Is there no fallback to english, if the language is not found?

With the edge version the issue isn't present anymore.

On the users and groups page it would be nice, if an entry also opens on double click instead of pressing Actions -> Edit. Maybe for the other pages as well.

@drakkan
Copy link
Owner

drakkan commented Feb 13, 2024

I cleared the cache and checked with developer tools. The browser language is german. With english or italian it works indeed. Is there no fallback to english, if the language is not found?

it should fallback to english but as I said is something I haven't yet tested.

Just to confirm, after clearing the cache, if you use a browser that supports German and English/Italian but uses German as the default language it doesn't work, if you switch to English or Italian as the default language it works. Did I get it right? Thanks

@mr-manuel
Copy link
Author

Yes thats correct.

@drakkan
Copy link
Owner

drakkan commented Feb 17, 2024

The translations fallback should be now fixed

7571852

@drakkan drakkan closed this as completed Feb 17, 2024
@mr-manuel
Copy link
Author

I downloaded the latest edge version and can confirm that this is now fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants