avoid nonce reuse for large payloads #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to a draft so nobody merges it until I'll I've done some perf testing |
due to using a counter size of 32bits in the stream cipher, only up to 256TB may be encrypted before a nonce reuse would occur. This solution checks if the counter has reached the limit on every increment. This _may_ add overhead or _may_ be free on some engines and I haven't benchmarked it
CluEleSsUK
force-pushed
the
fix/nonce-reuse
branch
from
daa3eb2
to
843389a
Compare
|
So I've successfully tested this with a payload of 2^28 chars. Theoretically V8 should be able to handle 2^29 - 24 chars, but when I try with this I get the error Either way, I think this is a reasonable limitation for now. If people have a use case for encrypting massive payloads they may have to resort to the go lib or do some fiddling themselves. |
AnomalRoil
reviewed
Jan 23, 2023
AnomalRoil
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to using a counter size of 32bits in the stream cipher, only up to 256TB may be encrypted before a nonce reuse would occur. This solution checks if the counter has reached the limit on every increment.
This may add overhead or may be free on some engines and I haven't benchmarked it