Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .eval function #31

Closed
3 tasks
saragee3 opened this issue Dec 6, 2020 · 3 comments · Fixed by #42
Closed
3 tasks

Support for .eval function #31

saragee3 opened this issue Dec 6, 2020 · 3 comments · Fixed by #42

Comments

@saragee3
Copy link
Member

saragee3 commented Dec 6, 2020

Summary

What:

Similar to https://github.com/puppeteer/puppeteer/blob/v5.5.0/docs/api.md#pageevaluatepagefunction-args. Sinco v1's HeadlessBrowser class already has a click function that pretty much fulfills this requirement. Argument should be a callback in this case.

Why:
#19 (comment)

User will be able to execute commands on the dev console. This could be used for scraping information, targeting children devs for testing ui, etc.

Acceptance Criteria

Below is a list of tasks that must be completed before this issue can be closed.

  • Write documentation
  • Write unit tests
  • Write integration tests

Example Pseudo Code (for implementation)

I assume that it will mirror the existing click function.

Naming

  • eval
  • exec
  • ..... open
@saragee3
Copy link
Member Author

@ebebbington any suggestions on naming? also, when is the projected sinco v1 release date? seems like an easy enough change that i could merge this into v1 too

@ebebbington
Copy link
Member

I think eval is ok - maybe things like query? I like exec too, I guess I’m just trying to find words that match the name for running code on the dev console

Projected release is for end of 2020... lol, was hoping to get a second review on it (also as we’re doing multiple reviews based on PR type), but if you want to tackle it now or this year then feel free to start :)

@saragee3
Copy link
Member Author

cool, let's go with eval for now n branch off of v1! i suggested the PR by type on a phone rant one day lol do you like it so far... or too many hurdles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants