Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Path of Chrome To Run? #33

Closed
4 tasks
ebebbington opened this issue Dec 11, 2020 · 1 comment · Fixed by #62
Closed
4 tasks

Specify Path of Chrome To Run? #33

ebebbington opened this issue Dec 11, 2020 · 1 comment · Fixed by #62

Comments

@ebebbington
Copy link
Member

Summary

What:

Not enitely sure how this would be done, or if it can be, but i think it'll be good to specify what chrome version to use (and at a later point, which other browser versions to use when more are supported)

Why:

When you're running browser tests, the browser version is key - something might break or might not work on one version, but work on another. For example, if i have a prod app, i might want to tell it on the following browsers:

  • Chrom v68
  • Chrome latest
  • Chrome v67 (maybe i want to support users using this version, so i wanna make sure everything works here too)

Acceptance Criteria

Below is a list of tasks that must be completed before this issue can be closed.

  • Write documentation
  • Write unit tests
  • Write integration tests
  • Da feature

Example Pseudo Code (for implementation)

// Add example pseudo code for implementation
@ebebbington
Copy link
Member Author

Don't think it's possible, in the sense of being able to do const Sinco = new HeadlessBrowser({ version: 68 }) because the chrome. browser points to the users installation

But maybe we could allow a path for the config, eg from a users perspective:

$ alias chome_v68="/Users/.../chrome.68.exe" # or export CHROME_V68="..."
$ cat app_test.ts

const Sinco = new HeadlessBrowser({ path: "chrome_v68" }) # or path: "$CHROME_V68"

Internally, the above would look like:

constructor (configs) {
  this.path = configs.path
}
public start () {
  Deno.run({
    cmd: [..., this.configs.path]
  })
}

@ebebbington ebebbington changed the title Specify Chrome Version To Run? Specify Path of Chrome To Run? Dec 11, 2020
@ebebbington ebebbington linked a pull request Apr 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant