Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinco Doesnt Clean Up After Failed Assertion Method #38

Closed
ebebbington opened this issue Jan 9, 2021 · 0 comments · Fixed by #39
Closed

Sinco Doesnt Clean Up After Failed Assertion Method #38

ebebbington opened this issue Jan 9, 2021 · 0 comments · Fixed by #39
Assignees
@ebebbington
Labels
Bug Something isn't working as expected

Comments

@ebebbington
Copy link
Member

Summary

A clear and concise summary of the bug.

Steps To Reproduce The Bug

  1. Create a test using this code: https://staging.drash.io/sinco/v1.x/#/tutorials/custom-assertions
  2. Replace whatever is in assertSee with anything else
  3. Run test, expect to fail
  4. Run test again, it will now hang

Expected Behavior

It should not hang after running after a failed test

Suggested Solution(s)

Assertion methods should cleanup on the event that an assertion will fail
@ebebbington ebebbington added Bug Something isn't working as expected Needs Investigation This item needs to be investigated further labels Jan 9, 2021
@ebebbington ebebbington self-assigned this Jan 9, 2021
@ebebbington ebebbington added Priority: Medium and removed Needs Investigation This item needs to be investigated further labels Jan 9, 2021
ebebbington pushed a commit that referenced this issue Jan 9, 2021
[#38-cleanup-in-assertions] Add custom assertions test from docs
38421c2
ebebbington pushed a commit that referenced this issue Jan 9, 2021
[#38-cleanup-in-assertions] Cleanup in assertions annd add test for this
40155ce
@ebebbington ebebbington mentioned this issue Jan 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebebbington ebebbington

Labels
Bug Something isn't working as expected
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Assertion methods dont cleanup when failing drashland/sinco
1 participant
@ebebbington