Get Value From Attribute

[ebebbington]

Summary

What: Add a public method to HeadlessBrowser to get the value for a given elements attribute

[ebebbington]

Now we have evaluatePage, I feel it makes adding this feature pointless?

For example we can now do:

// html: <input id="username" user-id="2">
await Sinco.evaluatePage(() => {
  return document.getElementById("username").getAttribute("user_id") // "2"
})

[ebebbington]

can add it to element class? eg

function attribute(name: string) {
  send("document.querySelector(this.selector)[name]
}

[ebebbington]

Following v4, it should be:

async function attribute(name: string, value?: string) {
  if (value) {
    return await this.#page.evaluate(`${this.method}('${this.selector}').setAttribute('${name}', '${value}')`)
  }
  return await this.#page.evaluate(`${this.method}('${this.selector}').getAttribute('${name}')`)
}

[ebebbington]

or im thinking getAttribute and setAttribute to be more inline with the browser api

[ebebbington]

Gonna try start working on this, this week