-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Docker #46
Comments
ebebbington
pushed a commit
that referenced
this issue
Feb 4, 2021
ebebbington
pushed a commit
that referenced
this issue
Feb 4, 2021
ebebbington
pushed a commit
that referenced
this issue
Feb 4, 2021
ebebbington
pushed a commit
that referenced
this issue
Feb 4, 2021
…use ubuntu runner for these tests
ebebbington
pushed a commit
that referenced
this issue
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
What:
I tried using Sinco, but because my project is in a docker environment, i am unable to (some extra options are needed). This is to add support for docker
Why:
Adding support for docker is crucial in the end game because a lot fo sites use it, thus the tests will be ran inside the docker environment.
Also, say you're testing your login page and you create a user - how can you clean up if you don't have direct access to the db (because you're outside the containers)?
Acceptance Criteria
Below is a list of tasks that must be completed before this issue can be closed.
Example Pseudo Code (for implementation)
I've got it working, and the changes seem to be:
--no-sandbox
is needed to be added when running chrome inside Sinco'sbuild
methodWhen
goTo
ing, the hostname needs to be the container name. For example, using docker compos,e i have a container running that uses drash and is listening on port 1667, and my test file looks like:The text was updated successfully, but these errors were encountered: