Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Capture a Screenshot #79

Closed
2 of 4 tasks
SnoCold opened this issue Aug 3, 2021 · 5 comments · Fixed by #83
Closed
2 of 4 tasks

To Capture a Screenshot #79

SnoCold opened this issue Aug 3, 2021 · 5 comments · Fixed by #83
Assignees

Comments

@SnoCold
Copy link
Collaborator

SnoCold commented Aug 3, 2021

Summary

What: Page Screenshots

Ability to take page and element screenshots. possibly time-stamped but with option to provide filename

Why:

Taking screenshots is a good way to document UI tests

Acceptance Criteria

Below is a list of tasks that must be completed before this issue can be closed.

  • Write documentation
  • Write unit tests
  • Write integration tests
  • {add more checkboxes required by this issue as needed}

Example Pseudo Code (for implementation)

sinco.takeScreenshot(params?:{})// Add example pseudo code for implementation
@SnoCold
Copy link
Collaborator Author

SnoCold commented Aug 3, 2021

Please Assign it to me 👍 .

@ebebbington
Copy link
Member

I think screenshot As a method name is more descriptive and easier to type, what do you think?

@SnoCold
Copy link
Collaborator Author

SnoCold commented Aug 3, 2021

Yes true, lemme edit that

@SnoCold
Copy link
Collaborator Author

SnoCold commented Aug 3, 2021

maybe takeScreenshot?

@ebebbington
Copy link
Member

Yeah I think either works well :)

SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 4, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 4, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 11, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 11, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 11, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 11, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 12, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 12, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 12, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 12, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 13, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 14, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 16, 2021
SnoCold added a commit to SnoCold/sinco that referenced this issue Aug 19, 2021
ebebbington pushed a commit that referenced this issue Oct 24, 2021
* [#79] Starter changes to class

* [#79] Added a single test and some code to fail it

* [#79] to get base64 string; file write pending

* [#79] Testing selectors

* [#79] Added tests and Some docs

* [#79] deno fmt

* [#79] just changing test position

* [#79] Added Integration test and docs, integ fails

* [#79] Fixing Integrations test

* [#79] path fixes for windows

* deno fmt

* deno fmt

* [#79] Resolving code and the tests as well

* added method docs

* TimeStamp ':' fix

* [#79] Modifications based on review and discovery

* just a small change

* [#79] Added captureBeyondViewPort

* deno fmt

* [#79] Removing webp option because not supported

* Doc modifs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants