Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: combine into one test file #85

Closed
ebebbington opened this issue Aug 16, 2021 · 1 comment
Closed

Unit tests: combine into one test file #85

ebebbington opened this issue Aug 16, 2021 · 1 comment
Labels
Type: Chore Merging this pull request results in a patch version increment

Comments

@ebebbington
Copy link
Member

Summary

What:

Right now we have firefox and chrome tests, both test files are 99% the same. Combine test files into one by defining test cases inside a loop

Why:

Test files are 99% the same, thus duplicating a tonne of a logic, this could be solved by looping through each browser typr

How:

Pserudo code impl

// tests/unit/client_test.ts
["firefox", "chrome"].forEach(type => {  
Deno.test
(type + " goTo() ) => {} )
})
@ebebbington ebebbington added Type: Chore Merging this pull request results in a patch version increment Priority: Low labels Aug 16, 2021
@ebebbington
Copy link
Member Author

done as part of #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Merging this pull request results in a patch version increment
Development

No branches or pull requests

1 participant