Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert NoConsoleErrors method? #94

Closed
ebebbington opened this issue Dec 7, 2021 · 0 comments · Fixed by #98
Closed

Add assert NoConsoleErrors method? #94

ebebbington opened this issue Dec 7, 2021 · 0 comments · Fixed by #98
Assignees

Comments

@ebebbington
Copy link
Member

Really all this feature should be is: The user should be able to assert there are no errors in the console (and also be able to check and exclude?), so some examples could be

function assertNoErrors(exclusions: string[] = []) {
  // get err console messages
  // check non exist or exlucde the exclusions then check
}

const browser = await buildFor(...)
await browser.goTo(...)
await browser.assertNoErrors(['favicon.ico'])

Requirements:

  • Should be able to assert console has no errors (this aids in things like browser testing, all integration tests could pass, but webpack could silently fail, vue errors in the console and nothing is rendered)
  • Should be able to exclude errors when asserting (eg favicon.ico 404, if a user knows this will be an error, asserting shouldnt fail as this doesnt matter
@ebebbington ebebbington self-assigned this Dec 16, 2021
@ebebbington ebebbington linked a pull request Dec 16, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant