-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETag middleware #559
Comments
@ebebbington got it. ✋ |
@diveDylan Nice one! Be sure to read contributing for more information on tackling issues |
We're just in the process of updating the contributing documentation, just waiting for drashland/deno-drash-middleware#9 to be closed and it should give more information hoping its helpful :) |
ye... I have read the doc for coding. It seems has a lot work on compare the cache state |
I think how it would work is:
Though i am not sure and might. be looking in the wrong direction, the implementation of ETag is confusing to me |
Heres some resources if it helps: https://en.wikipedia.org/wiki/HTTP_ETag https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag If you want to discuss it in more detail then feel free to join our discord |
@ebebbington i have read all the doc on your list before 😄 |
Just thought it's worth mentioning!:) |
@ebebbington haha. it is indeed!:) |
@diveDylan have you made any progress on this? |
sorry, i forget this! I will join the discord and read contributing line. It is too late ... |
Original issue: https://github.com/drashland/deno-drash/issues/17
Ported over here because @crookse decided to make it a middleware instead (which is a good call), because it means it's usuable by users, but doesn't affect drash's performance at all - win win scenario
What
Add a new middleware for supporting the ETag header
Why
How
import { ETag } from "https://deno.land/x/drash-middleware@v{version}/etag/mod.ts"
Place third-party modules in your middleware directory's deps.ts file (if used)
Any Deno std module that's required by your package can be exported from the repo's root deps.ts file so that all middleware can import std modules from that single file.
Acceptance Criteria
README.md file showing how to use the middleware. Drash is a documentation-driven codebase, so the documentation is very important.
Develop ETag functionality
Tests
The text was updated successfully, but these errors were encountered: