Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI --ignore option #82

Closed
6 tasks done
crookse opened this issue Oct 22, 2020 · 0 comments · Fixed by #83
Closed
6 tasks done

CLI --ignore option #82

crookse opened this issue Oct 22, 2020 · 0 comments · Fixed by #83
Assignees
@crookse

Comments

@crookse
Copy link
Member

crookse commented Oct 22, 2020 •
edited

Summary

What: Add --ignore option that takes in directories or files

Why: If someone had a tests/data directory and wanted to run all tests in their tests/ directory, then currently the rhum command would try to test the files in tests/data, which would throw errors. It'd be nice to ignore any directories or files that shouldn't be tested.

Acceptance Criteria

  • Add --ignore subcommand option
    • Ignores files
    • Ignores directories
    • Should be usable as follows: --ignore=dir,dir, --ignore=dirs, --ignore=test1.ts,test2.ts, --ignore=test1.ts
  • Tests
  • Documentation
@crookse crookse self-assigned this Oct 22, 2020
This was referenced Oct 22, 2020
Closed
Merged
@crookse crookse linked a pull request Oct 28, 2020 that will close this issue
feat: CLI --ignore option #83
Merged
@crookse crookse changed the title --ignore option CLI --ignore option Oct 30, 2020
@crookse crookse changed the title CLI --ignore option feat: CLI --ignore option Oct 31, 2020
@crookse crookse changed the title feat: CLI --ignore option CLI --ignore option Nov 1, 2020
@crookse crookse closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crookse crookse

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: CLI --ignore option drashland/rhum
1 participant
@crookse