Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!todo Dragon tribal inflamed don't work with Grady. #645

Open
karlwilcox opened this issue Aug 15, 2023 · 1 comment
Open

!todo Dragon tribal inflamed don't work with Grady. #645

karlwilcox opened this issue Aug 15, 2023 · 1 comment
Labels
No Fix Likely Acknowledged as a problem but not a good use of limited time, sorry

Comments

@karlwilcox
Copy link
Collaborator

!todo Dragon tribal inflamed don't work with Grady.

@karlwilcox
Copy link
Collaborator Author

Depends a bit you mean by "doesn't work"(!)

Firstly, "inflamed" is a feature, which in DrawShield terms is a (usually quite small) part of a charge that can take a different colour. Because it is (usually) such a small part of a charge (and because coding it any other way is quite hard) features can only be plain colours (e.g. it would be pretty pointless to do something like a "lion gules armed ermine", the actual ermine spots would be really tiny...). 'inflamed' is a feature, so it only takes a plain colour, not grady. (Also remember that "grady" has absolutely NO heraldic precedent, i just added it because I thought it looked nice...)

There is a short-coming in the parser in that it should recognise more complex tinctures for features but it should then ignore them and produce a proper error message.

Now, I will admit that in the particular case of the tribal dragon the "inflamed" feature is actually bigger than the rest of the dragon so my earlier argument probably isn't valid but it is still hard to code up. Making the whole of the dragon grady looks nice though...

In short, I will try to fix the parser problem noted above, but the original issue is unlikely to be fixed, sorry.

@karlwilcox karlwilcox added the No Fix Likely Acknowledged as a problem but not a good use of limited time, sorry label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Fix Likely Acknowledged as a problem but not a good use of limited time, sorry
Projects
None yet
Development

No branches or pull requests

1 participant