Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not detect Drupal version cause it stops iterating when one of the possible URLs gets a 200 response #49

Closed
iammyr opened this issue Oct 17, 2018 · 2 comments
Closed

Can not detect Drupal version cause it stops iterating when one of the possible URLs gets a 200 response #49

iammyr opened this issue Oct 17, 2018 · 2 comments
Labels
bug Something isn't working hacktoberfest

Comments

@iammyr
Copy link
Contributor

iammyr commented Oct 17, 2018

If any of the URLs referred to in order to guess the Drupal version returns 200, even though given the response body does not allow to actually determine the version, the iteration stops (break).
Therefore, the next URLs are never checked.
@iammyr iammyr mentioned this issue Oct 17, 2018
Merged
@iammyr
Copy link
Contributor Author

iammyr commented Oct 17, 2018 •
edited

proposed fix 9bf691f

(would it be possible to mark this issue with the label "hacktoberfest", please? Thanks a million!)

@g0tmi1k g0tmi1k added hacktoberfest bug Something isn't working enhancement New feature or request and removed enhancement New feature or request labels Oct 18, 2018
g0tmi1k added a commit that referenced this issue Oct 19, 2018
@g0tmi1k
Merge pull request #50 from iammyr/master
fe63390 
proposed fixes for issues #49 #51 and #52
@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Oct 19, 2018

merged

@g0tmi1k g0tmi1k closed this as completed Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@g0tmi1k @iammyr